Skip to content

Commit

Permalink
Address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
icaraps committed Aug 3, 2020
1 parent 6fbbc1d commit 0b99aa8
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
3 changes: 2 additions & 1 deletion packages/gatsby-theme-parliament/src/components/NextPrev.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ const NextPrev = ({ nextPage, previousPage }) =>
) : null;

NextPrev.propTypes = {
nextPage: PropTypes.object
nextPage: PropTypes.object,
previousPage: PropTypes.object
};

export { NextPrev };
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import PropTypes from 'prop-types';

const NextSteps = ({ pages }) => {
return pages.length > 0 ? (
<View elementType="nav" marginTop="size-800">
<View marginTop="size-800">
<Heading4>Next steps</Heading4>
<ul
className="spectrum-Body--M"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,10 @@ const OnThisPage = ({ tableOfContents }) => {
}
}

setActiveHeadingLink(findActiveHeadingLink());
const activeHeadingLink = findActiveHeadingLink();
if (activeHeadingLink) {
setActiveHeadingLink(findActiveHeadingLink());
}
});

observer.observe(headingLink);
Expand Down
3 changes: 1 addition & 2 deletions packages/gatsby-theme-parliament/src/components/Resources.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ const Resources = ({ heading, links }) => {
<Link
href={link.props.href}
target="_blank"
rel="nofollow noopener noreferrer"
className="spectrum-Link spectrum-Link--quiet">
rel="nofollow noopener noreferrer">
<span
css={css`
display: inline-flex;
Expand Down

0 comments on commit 0b99aa8

Please sign in to comment.