-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaning up the codebase #285
Conversation
Hermann-Core
commented
Dec 9, 2024
•
edited
Loading
edited
- Add Clippy checks and suppress warnings and unused/dead code throughout the project
- Remove all unused dependencies across the project
- Upgrade all dependencies to their latest available versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, but i think there we some refactoring which were not really neccessary like changing all the calls to get(0)
to first()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Resolve conflicts
Cargo Clippy checks. It also explicitly signals the intent to access the first element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go 🚀