Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning up the codebase #285

Merged
merged 8 commits into from
Dec 20, 2024
Merged

cleaning up the codebase #285

merged 8 commits into from
Dec 20, 2024

Conversation

Hermann-Core
Copy link
Collaborator

@Hermann-Core Hermann-Core commented Dec 9, 2024

  • Add Clippy checks and suppress warnings and unused/dead code throughout the project
  • Remove all unused dependencies across the project
  • Upgrade all dependencies to their latest available versions

@Hermann-Core Hermann-Core self-assigned this Dec 9, 2024
@Hermann-Core Hermann-Core linked an issue Dec 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@Christiantyemele Christiantyemele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but i think there we some refactoring which were not really neccessary like changing all the calls to get(0) to first()

Copy link
Collaborator

@Blindspot22 Blindspot22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Resolve conflicts

@Hermann-Core
Copy link
Collaborator Author

Good, but i think there we some refactoring which were not really neccessary like changing all the calls to get(0) to first()

Cargo Clippy checks. It also explicitly signals the intent to access the first element.

Copy link
Collaborator

@Blindspot22 Blindspot22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🚀

@ndefokou ndefokou merged commit 2747ea5 into main Dec 20, 2024
1 check passed
@Hermann-Core Hermann-Core deleted the 278-cleanup-the-codebase branch December 20, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup the codebase
5 participants