Modified JWK to reflect spec #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 10, 2023 14:20
hugoib
changed the title
|
On hold, tests are broken inside did-endpoint, fixing... |
hugoib
changed the title
|
Ready for review again 👍🏻 |
|
@IngridPuppet I tracked down the problem. I am using https://github.com/jinxdash/prettier-plugin-rust inside my VS Code. I will disable it. |
francis-pouatcha
requested changes
Oct 24, 2023
francis-pouatcha
requested review from
francis-pouatcha
and removed request for
IngridPuppet
|
Formating makes review tough. |
francis-pouatcha
requested changes
Oct 24, 2023
|
Closed and opened a new, cleaner: #70 |
francis-pouatcha
added a commit
that referenced
this pull request
Nov 9, 2023
…spec Clean: Modified JWK to reflect spec #60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49
Improved JWK handling to comply with the spec https://datatracker.ietf.org/doc/html/rfc7517. Implementation inspired by https://github.com/RustCrypto/JOSE.