Support moto by allowing non-awaitable content #1007
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
PR adds a patch to
endpoint.convert_to_response_dict
such that it can work with moto while not changing the expected behavior of the method. Tests are addedIssue (#979)
The primary problem with moto integration is this method. There are 2 main issues with that method
raw
to haveraw_headers
just to convert the headers to lowercase.await
.How to reproduce the error
Resolution
It's a two part solution
await
ing for awaitable objects.Assumptions
Alternative methods considered
I tried consolidating all the changes in just one repo (see: #1004) but it's not possible
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions