Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sizing month header on every frame and add more calendar model caching #321

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix sizing month header on every frame and add more calendar model caching #321

merged 1 commit into from
Nov 14, 2024

Conversation

bryankeller
Copy link
Contributor

Details

This PR fixes 2 issues:

  1. I was never caching the result of self-sizing a month header, causing us to call systemLayoutSizeFitting on every frame 💀
  2. We weren't caching calendar item models for some calendar slots, like for day ranges and month backgrounds

Related Issue

N/A

Motivation and Context

Performance improvements

How Has This Been Tested

Example app, Airbnb app

@bryankeller bryankeller added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 14, 2024
@bryankeller bryankeller force-pushed the bk/add-missing-calendar-item-model-cache branch from c576614 to cfc3458 Compare November 14, 2024 01:57
@bryankeller bryankeller force-pushed the bk/add-missing-calendar-item-model-cache branch from cfc3458 to ded628f Compare November 14, 2024 05:43
brynbodayle
brynbodayle approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@brynbodayle brynbodayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add some tests for this

@bryankeller
Copy link
Contributor Author

Hmm yeah, I'll think about how that might be possible. We don't expose whether something was returned from cache or not, but I bet there's some way we could get it tested.

@bryankeller bryankeller merged commit 697c6f2 into master Nov 14, 2024
2 checks passed
@bryankeller bryankeller deleted the bk/add-missing-calendar-item-model-cache branch November 14, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brynbodayle brynbodayle brynbodayle approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryankeller @brynbodayle