More comments #2630
Draft
More comments #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Aug 17, 2022
| @@ -73,6 +77,8 @@ Other Style Guides | |||
| - `symbol` | |||
| - `bigint` | |||
|
|
|||
| *Goes over numbers* | |||
| @@ -91,6 +97,8 @@ Other Style Guides | |||
| - `array` | |||
| - `function` | |||
|
|
|||
| *Goes over arrays* | |||
| @@ -109,6 +117,8 @@ Other Style Guides | |||
|
|
|||
| > Why? This ensures that you can’t reassign your references, which can lead to bugs and difficult to comprehend code. | |||
|
|
|||
| *Vars and Consts* | |||
| @@ -141,6 +151,8 @@ Other Style Guides | |||
| <a name="references--block-scope"></a><a name="2.3"></a> | |||
| - [2.3](#references--block-scope) Note that both `let` and `const` are block-scoped, whereas `var` is function-scoped. | |||
|
|
|||
| *Goes over scopes in Javascript* | |||
| @@ -162,6 +174,8 @@ Other Style Guides | |||
| <a name="objects--no-new"></a><a name="3.1"></a> | |||
| - [3.1](#objects--no-new) Use the literal syntax for object creation. eslint: [`no-new-object`](https://eslint.org/docs/rules/no-new-object) | |||
|
|
|||
| *Goes over objects* | |||
Comment on lines
-254
to
+257
| <Foo style={{ left: "20px" }} /> | ||
| <Foo className='bad example' /> | ||
|
|
||
| // good | ||
| <Foo style={{ left: '20px' }} /> | ||
| <Foo className="good example" /> |
There was a problem hiding this comment.
these MUST remain as "style" with an object literal; there's nothing wrong with the current examples.
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2626