Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHA-993: Add product-model.updated.delta documentation #991

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomglvng
Copy link
Collaborator

@tomglvng tomglvng commented Jan 7, 2025

No description provided.

@tomglvng tomglvng self-assigned this Jan 7, 2025
@akeneo-secops
Copy link

Gitleaks PR check

🟢 We detected no secrets within this PR! Good job 🎉

Comment on lines +1696 to +1706
- Changes to product model properties, such as:
- Changes in category association, such as:
- Adding the product model to a category
- Removing the product model from a category
- Changes in group association, such as:
- Adding the product model to a group
- Removing the product model from a group
- Adjustments to product model values
- Alterations to product model associations, including:
- Standard associations
- Quantified associations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little warning about singular versus plural, may be it can be harmonized

"id": "018e32f9-dfe4-760e-a273-5da1c089dfdb",
"type": "com.akeneo.pim.v1.product-model.updated.delta",
"source": "pim",
"subject": "srnt-whatever",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"subject": "srnt-whatever",
"subject": "019256aa-7f77-7f58-bc8c-770f7e369c5b",

out of the event platform, the subject is the subscription uuid, not the pim tenant id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants