remove all caching

akgulebubekir · Sep 14, 2024 · 67278bf · 67278bf
1 parent 68d3149
commit 67278bf
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 359 deletions.
diff --git a/Maui.DataGrid/Collections/ConcurrentLRUCache.cs b/Maui.DataGrid/Collections/ConcurrentLRUCache.cs
diff --git a/Maui.DataGrid/CompatibilitySuppressions.xml b/Maui.DataGrid/CompatibilitySuppressions.xml
@@ -1,46 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
 <Suppressions xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>F:Maui.DataGrid.DataGrid.CacheSizeProperty</Target>
-    <Left>lib/net8.0/Maui.DataGrid.dll</Left>
-    <Right>lib/net8.0/Maui.DataGrid.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>F:Maui.DataGrid.DataGrid.CachingEnabledProperty</Target>
-    <Left>lib/net8.0/Maui.DataGrid.dll</Left>
-    <Right>lib/net8.0/Maui.DataGrid.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:Maui.DataGrid.DataGrid.get_CacheSize</Target>
-    <Left>lib/net8.0/Maui.DataGrid.dll</Left>
-    <Right>lib/net8.0/Maui.DataGrid.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:Maui.DataGrid.DataGrid.get_CachingEnabled</Target>
-    <Left>lib/net8.0/Maui.DataGrid.dll</Left>
-    <Right>lib/net8.0/Maui.DataGrid.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:Maui.DataGrid.DataGrid.set_CacheSize(System.Int32)</Target>
-    <Left>lib/net8.0/Maui.DataGrid.dll</Left>
-    <Right>lib/net8.0/Maui.DataGrid.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:Maui.DataGrid.DataGrid.set_CachingEnabled(System.Boolean)</Target>
-    <Left>lib/net8.0/Maui.DataGrid.dll</Left>
-    <Right>lib/net8.0/Maui.DataGrid.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-</Suppressions>
+</Suppressions>
diff --git a/Maui.DataGrid/DataGrid.xaml.cs b/Maui.DataGrid/DataGrid.xaml.cs
@@ -115,18 +115,6 @@ public partial class DataGrid
                 }
             });
 
-    /// <summary>
-    /// Gets or sets a value indicating whether the DataGrid allows caching.
-    /// </summary>
-    public static readonly BindableProperty CachingEnabledProperty =
-        BindablePropertyExtensions.Create<DataGrid, bool>(false);
-
-    /// <summary>
-    /// Gets or sets a value indicating whether the DataGrid allows caching.
-    /// </summary>
-    public static readonly BindableProperty CacheSizeProperty =
-        BindablePropertyExtensions.Create<DataGrid, int>(DefaultCacheSize);
-
     /// <summary>
     /// Gets or sets the Columns for the DataGrid.
     /// </summary>
@@ -810,26 +798,6 @@ public IEnumerable ItemsSource
         set => SetValue(ItemsSourceProperty, value);
     }
 
-    /// <summary>
-    /// Gets or sets a value indicating whether caching is enabled in the DataGrid.
-    /// Default value is False.
-    /// </summary>
-    public bool CachingEnabled
-    {
-        get => (bool)GetValue(CachingEnabledProperty);
-        set => SetValue(CachingEnabledProperty, value);
-    }
-
-    /// <summary>
-    /// Gets or sets a value indicating the size of the cache for the DataGrid.
-    /// Default value is 100000.
-    /// </summary>
-    public int CacheSize
-    {
-        get => (int)GetValue(CacheSizeProperty);
-        set => SetValue(CacheSizeProperty, value);
-    }
-
     /// <summary>
     /// Gets or sets columns of the DataGrid.
     /// </summary>
@@ -1384,11 +1352,11 @@ private IEnumerable<object> GetSortedItems(IList<object> unsortedItems, SortData
         {
             case SortingOrder.Ascendant:
                 _ = columnToSort.SortingIcon.RotateTo(0);
-                items = unsortedItems.OrderBy(x => x.GetValueByPath(columnToSort.PropertyName, CachingEnabled, CacheSize));
+                items = unsortedItems.OrderBy(x => x.GetValueByPath(columnToSort.PropertyName));
                 break;
             case SortingOrder.Descendant:
                 _ = columnToSort.SortingIcon.RotateTo(180);
-                items = unsortedItems.OrderByDescending(x => x.GetValueByPath(columnToSort.PropertyName, CachingEnabled, CacheSize));
+                items = unsortedItems.OrderByDescending(x => x.GetValueByPath(columnToSort.PropertyName));
                 break;
             case SortingOrder.None:
                 return unsortedItems;

diff --git a/Maui.DataGrid/DataGridColumn.cs b/Maui.DataGrid/DataGridColumn.cs
@@ -407,7 +407,7 @@ internal void InitializeDataType()
                 }
             }
 
-            DataType = rowDataType?.GetPropertyTypeByPath(PropertyName, DataGrid.CachingEnabled, DataGrid.CacheSize);
+            DataType = rowDataType?.GetPropertyTypeByPath(PropertyName);
         }
         catch (Exception ex)
             when (ex is NotSupportedException or ArgumentNullException or InvalidCastException)