Fix crash on .NET 9 #201
Merged
Fix crash on .NET 9 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I apologize for the formatting changes. My linter decided to reformat the file. |
|
Thank you for the contribution. I will add AOT and trimming support as a roadmap item, although as you mention it may just force reflection for the time being. However, I cannot see how this fixes any crash. Seems like it only has formatting changes. |
|
Ok, I see now it is the x:DataType={x:Null} that is the fix. |
|
Would be nice to get a force-push without the formatting changes, for clarity. |
|
Done. |
|
I made some attempted changes to improve things with respect to trimming and AOT. Let me know if they seem good to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #200
This isn't a great fix in that this library is still not trimming and aot compatible, but this gets it to at least not-crash in client builds. This library was already incompatible for trimming and aot as x:Object previously just forced reflection bindings anyways in .NET 8.