Dev #8
Merged
Dev #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update PhoneBookContext.db * Update Create.cshtml * Update Delete.cshtml * Update Details.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Edit.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Index.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update _Layout.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update site.css Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> --------- Co-authored-by: akinin <3820354+akinin@users.noreply.github.com>
* Update PhoneBookContext.db * Update Create.cshtml * Update Delete.cshtml * Update Details.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Edit.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Index.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update _Layout.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update site.css Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update PhoneBookController.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update PhonebookContext.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update IdentityContext.db Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update PhoneEdit.csproj Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Program.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Edit.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Index action Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update PhonebookContext.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Create BookEntriesViewModel.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update PhoneEdit.csproj Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Program.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Create PhoneBookService.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Create.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Edit.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Index.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update _Layout.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Scaffold Identity pages Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> --------- Co-authored-by: akinin <3820354+akinin@users.noreply.github.com>
* Update PhoneBookContext.db * Update Create.cshtml * Update Delete.cshtml * Update Details.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Edit.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Index.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update _Layout.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update site.css Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update PhoneBookController.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update PhonebookContext.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update IdentityContext.db Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update PhoneEdit.csproj Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Program.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Edit.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Index action Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update PhonebookContext.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Create BookEntriesViewModel.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update PhoneEdit.csproj Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Program.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Create PhoneBookService.cs Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Create.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Edit.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update Index.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Update _Layout.cshtml Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> * Scaffold Identity pages Co-Authored-By: akinin <3820354+akinin@users.noreply.github.com> --------- Co-authored-by: akinin <3820354+akinin@users.noreply.github.com>
akinin
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Update UI elements styles in Index.cshtml In the PhoneBook Index view, changes have been made in the style of the badge and buttons to partially fix their appearance. This included modifying the background color for the badge and varying the width and icon dimensions of the Edit, Details, and Delete buttons. * Simplify layout by removing environment-specific CSS and JS The commit removes the distinction between development and other environments for CSS and Javascript in the _Layout.cshtml file. It simplifies the page layout by consistently using local versions of Bootstrap and Font-Awesome, and by modifying the placement of certain elements. All environments will now use the same CSS and JS, which streamlines testing and deployment. * Add check for non-empty model in Index view This commit includes a check to ensure that the list provided to the Index view of the PhoneBook is not empty. Previously, if the list was empty, the view would attempt to take the first entry and fail. The if statement ensures this error is avoided. * Refactor search functionality in PhoneBookController Search string validation was simplified and applied directly to the database query rather than to an in-memory list of entries. Further, the ordering and pagination of entries were also shifted to the query level, improving efficiency and performance. * Refactor database connection setup and enhance options configuration Removed excessive use of `MySqlConnector` and refactored the way connection strings are retrieved. Also applied cleaner structuring for adding database context services. Added configuration for `DefaultUserOptions` and conditional addition of `DatabaseDeveloperPageExceptionFilter` based on the environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.