feat: test DynamoDB projections #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Jan 6, 2025
|
|
||
| client | ||
| .batchWriteItem( | ||
| BatchWriteItemRequest.builder |
There was a problem hiding this comment.
This is not checking the unprocessedItems so it's suffering from the same problem as akka/akka-projection#1260
I also created issue akka/akka-projection#1286
There was a problem hiding this comment.
Good point. Using a provided retry utility sounds good. Will add this.
There was a problem hiding this comment.
| import software.amazon.awssdk.services.dynamodb.model.WriteRequest | ||
|
|
||
| class DynamoDBProjectionHandler(projectionId: ProjectionId, projectionIndex: Int, readOnly: Boolean, failEvery: Int) | ||
| extends DynamoDBTransactHandler[EventEnvelope[ConfigurablePersistentActor.Event]] { |
There was a problem hiding this comment.
We should also have a variant that is not using exactly-once, but still one-by-one handler
There was a problem hiding this comment.
Yes. Just adding the equivalent of what's there already in this PR. Will follow up after by extending to a singular at-least-once, and make it more configurable between them — just commented out in each implementation currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft on restructuring in #16