chore: Extract common parts of replay code #1288
Merged
+129
−292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Jan 8, 2025
| .validate(envelope) | ||
| .flatMap { | ||
| case Accepted => | ||
| accepted(envelope) |
There was a problem hiding this comment.
I looked at diffs of the the code that were in the handlers and the only difference was how the Accepted case was handled.
There was a problem hiding this comment.
Yeah, seemed that would be the case.
| @@ -726,6 +491,8 @@ private[projection] object DynamoDBProjectionImpl { | |||
| import DynamoDBOffsetStore.Validation._ | |||
| implicit val ec: ExecutionContext = system.executionContext | |||
|
|
|||
| // This is similar to DynamoDBProjectionImpl.replayIfPossible but difficult to extract common parts | |||
| // since this is flow processing | |||
There was a problem hiding this comment.
For the flow handler I didn't see an easy way to reuse the same code so kept it as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.