Implement f64 method polyfills with intrinsics support #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you very much! |
al8n
approved these changes
Dec 4, 2023
|
This obviously need a bit of extra work at the moment, as it seems that the msvc toolchain on windows does not provide the implementations for the intrinsics. I'll make another revision. I'll have to see if I can track down why the use_hash_once is causing issues in CI, but not on my local machine. |
The intrinsics can be added back with more restrictive cfg attrs when they can be validated for availability.
This removes the feature flag for intrinsics, as I removed their use in `polyfill.rs`. Fixed type ambiguity errors in `wtinylfu_caches.rs` benchmark file. Fixed clippy warning for renamed check.
|
@al8n I have pulled out the use of intrinsics, as they appear to have some errors even with the feature gate enabled on nightly. I've also added some fixes for the benches and clippy warnings, as mentioned in the notes for the most recent commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a f64 math polyfill to support no_std environments.
If
stdis used, the functions refer to their standard library implementations.If
stdis removed, the functions uselibm's portable software implementation.If
stdis removed and the nightly feature is enabled, rust's unstable access to the math intrisics is restore which should be identical tostd's implementation.