adds clues.Inherit for client propagation #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandeyabs
reviewed
Dec 3, 2024
ryanfkeepers
force-pushed
the
otel-metrics-2
branch
from
1515bdb to
72b7e4c
Compare
ryanfkeepers
force-pushed
the
inherit-clients
branch
from
224779b to
a284603
Compare
pandeyabs
approved these changes
Dec 4, 2024
ryanfkeepers
force-pushed
the
inherit-clients
branch
from
a284603 to
7b4f7a6
Compare
Since clues is designed around strict context-bound propagation of values, it runs across some hiccups which other packages tend to solve with global instances. Namely, patterns where a main func initializes clients (such as otel) but processes requests with a separate context, as is traditional with http servers. The Inherit(from, to) func gives callers a plug which they can use to propagate clients from their initialized context into individual request-bound contexts, which can be utilized in a http handler middleware.
ryanfkeepers
force-pushed
the
inherit-clients
branch
from
7b4f7a6 to
6d24669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since clues is designed around strict context-bound propagation of values, it runs across some hiccups which other packages tend to solve with global instances. Namely, patterns where a main func initializes clients (such as otel) but processes requests with a separate context, as is traditional with http servers.
The Inherit(from, to) func gives callers a plug which they can use to propagate clients from their initialized context into individual request-bound contexts, which can be utilized in a http handler middleware.