Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use component wrapper on skip link component #4520

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Use component wrapper on skip link component #4520

merged 1 commit into from
Jan 6, 2025

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Jan 6, 2025

What

  • Adds the component wrapper helper to the skip link component.

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4520 January 6, 2025 14:01 Inactive
@AshGDS AshGDS force-pushed the skip-link-component-wrapper branch from ebc177c to 31ff8a9 Compare January 6, 2025 14:02
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4520 January 6, 2025 14:02 Inactive
@AshGDS AshGDS marked this pull request as ready for review January 6, 2025 14:42
@AshGDS AshGDS requested a review from andysellick January 6, 2025 14:42
@AshGDS AshGDS force-pushed the skip-link-component-wrapper branch from 31ff8a9 to 639c679 Compare January 6, 2025 16:24
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4520 January 6, 2025 16:24 Inactive
@AshGDS AshGDS force-pushed the skip-link-component-wrapper branch from 639c679 to 39d6112 Compare January 6, 2025 16:32
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4520 January 6, 2025 16:32 Inactive
@AshGDS AshGDS merged commit 5a43af3 into main Jan 6, 2025
12 checks passed
@AshGDS AshGDS deleted the skip-link-component-wrapper branch January 6, 2025 16:36
@andysellick andysellick mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysellick andysellick andysellick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshGDS @andysellick @govuk-ci