Use component wrapper on step nav header component #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
force-pushed
the
step-nav-header-component-wrapper
branch
from
785b48d to
97f42d4
Compare
AshGDS
force-pushed
the
step-nav-header-component-wrapper
branch
from
97f42d4 to
61673c8
Compare
andysellick
approved these changes
Jan 6, 2025
| ga4_data = { | ||
| event_name: "navigation", | ||
| type: "super breadcrumb", | ||
| index_link: "1", | ||
| index_total: "1", | ||
| }.to_json | ||
| end | ||
|
|
||
| shared_helper = GovukPublishingComponents::Presenters::SharedHelper.new(local_assigns) |
There was a problem hiding this comment.
This looks fine but I was a bit confused by it being in two separate commits. Maybe worth either merging them or adding something to the commit message to clarify that the shared helper is no longer needed as the margin bottom is now provided by the component wrapper helper?
There was a problem hiding this comment.
Good point - will do, thanks!
Also removes the shared helper.
AshGDS
force-pushed
the
step-nav-header-component-wrapper
branch
from
61673c8 to
edbf9f2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
step nav headercomponent.Why
As the trello card states:
Visual changes
None.