Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use component wrapper on translation nav component #4530

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Use component wrapper on translation nav component #4530

merged 1 commit into from
Jan 8, 2025

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Jan 8, 2025

What

  • Adds the component wrapper helper to the translation nav component.

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4530 January 8, 2025 10:49 Inactive
@AshGDS AshGDS force-pushed the translation-nav-component-wrapper branch from 3b05077 to 358e19f Compare January 8, 2025 10:49
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4530 January 8, 2025 10:50 Inactive
@AshGDS AshGDS marked this pull request as ready for review January 8, 2025 10:52
@AshGDS AshGDS requested a review from andysellick January 8, 2025 10:52
@AshGDS AshGDS merged commit 61d09e4 into main Jan 8, 2025
12 checks passed
@AshGDS AshGDS deleted the translation-nav-component-wrapper branch January 8, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysellick andysellick andysellick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshGDS @andysellick @govuk-ci