Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ContactEntityMapper.cs #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

filippobottega
Copy link

I propose to change target.Inner.FullName to target.Inner.Title as ContactEntityMapper.cs line 257:

...
if (!string.IsNullOrEmpty(source.Inner.FileAs))
target.Title = source.Inner.FileAs;
...

I propose to change target.Inner.FullName to target.Inner.Title as ContactEntityMapper.cs line 257:

...
      if (!string.IsNullOrEmpty(source.Inner.FileAs))
        target.Title = source.Inner.FileAs;
...
@filippobottega
Copy link
Author

The problem si that FileAs should be mapped with contact Name in case the name will be empty.
The same if FormatName is defined and Name is empty. FormatName should be mapped with Name in Outllok to prevent Outlook from parsing FormatName and splitting the value into multiple parts using space as character separator.

The field Title is not the correct field to use because in Android address book the Title is not displayed.
Name is displayed correctly.
The rule to sync Outlook with Google should be to map FileAs to FormatName and if the FileAs is a generic description or the name of a company, the value should be assigned to the Name field of Name entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant