Fix some endpoints by upgrading them to v2, fix all the tests #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you please review the PR? |
|
Hi @tsolakoua @minjikarin @anthonyroux |
tsolakoua
reviewed
Sep 6, 2023
| @@ -61,7 +61,7 @@ public FlightOffer[] get(Params _params) | |||
| { | |||
| try | |||
| { | |||
| Response response = client.get("/v1/shopping/flight-offers", _params); | |||
| Response response = client.get("/v2/shopping/flight-offers", _params); | |||
There was a problem hiding this comment.
The actual and correct API call of the Flight Offers Search API is at this class. It seems at the file FlightOffers.cs it hasn't been removed from the past.
tsolakoua
reviewed
Sep 6, 2023
| @@ -13,7 +13,10 @@ public class TravelRestrictionsTest | |||
| public void Get_Restrictions() | |||
| { | |||
| var amadeus = GetAmadeusBuild(); | |||
| DiseaseAreaReport response = amadeus.dutyOfCare.diseases.covid19AreaReport.get(Params.with("countryCode", "US")); | |||
| DiseaseAreaReport response = amadeus.dutyOfCare.diseases.covid19AreaReport.get(Params | |||
There was a problem hiding this comment.
The Travel Restrictions API has been recently completely decommissioned, so there is no need to update this anymore.
3 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran all the tests, all are passing now