Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add performance schema for Aquila #167

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Conversation

guomanmin
Copy link
Contributor

@guomanmin guomanmin commented Jan 22, 2024

Issue #, if available:

Description of changes:
adding new device geometry and control fields data to aquila device

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@guomanmin guomanmin requested a review from a team as a code owner January 22, 2024 22:50
@AbeCoull
Copy link
Contributor

Would it make sense to use Annotated with a Field for Decimal typing?

@AbeCoull
Copy link
Contributor

@guomanmin guomanmin changed the title feat: add newly added schema from quera feat: add newly added schema for Aquila Jan 23, 2024
@guomanmin guomanmin changed the title feat: add newly added schema for Aquila feat: add performance schema for Aquila Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d53cada) 100.00% compared to head (03b0ec3) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        93           
  Lines         1361      1398   +37     
  Branches        25        25           
=========================================
+ Hits          1361      1398   +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guomanmin guomanmin force-pushed the feature/quera_schema_update branch from c9cd67a to 7ddce41 Compare January 25, 2024 22:12
@guomanmin guomanmin dismissed AbeCoull’s stale review January 25, 2024 22:17

This request has been incorporated

@guomanmin guomanmin merged commit d779a94 into main Jan 29, 2024
42 checks passed
@guomanmin guomanmin deleted the feature/quera_schema_update branch January 29, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants