Skip to content

Commit

Permalink
fix: address todos (#730)
Browse files Browse the repository at this point in the history
  • Loading branch information
ajberdy authored Oct 9, 2023
1 parent 0db4972 commit a7e799c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
7 changes: 3 additions & 4 deletions src/braket/jobs/hybrid_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ def hybrid_job(
include_modules (Union[Union[str, ModuleType], Iterable[Union[str, ModuleType]]]): Either a
single module or module name or a list of module or module names referring to local
modules to be included. Default value `[]`
todo: confirm docs
modules to be included. Any references to members of these modules in the hybrid job
algorithm code will be serialized as part of the algorithm code. Default value `[]`
dependencies (Optional[Union[str, Path]]): Path (absolute or relative) to a requirements.txt
file to be used. todo: confirm docs
file to be used for the hybrid job.
local (bool): Whether to use local mode for the hybrid job. Default `False`
Expand Down Expand Up @@ -213,7 +213,6 @@ def __exit__(self, exc_type, exc_val, exc_tb):
def _serialize_entry_point(entry_point: Callable, args, kwargs) -> str:
"""Create an entry point from a function"""

# todo: catch serialization errors
def wrapped_entry_point():
"""Partial function wrapping entry point with given parameters"""
return entry_point(*args, **kwargs)

Check warning on line 218 in src/braket/jobs/hybrid_job.py

View check run for this annotation

Codecov / codecov/patch

src/braket/jobs/hybrid_job.py#L218

Added line #L218 was not covered by tests
Expand Down
2 changes: 0 additions & 2 deletions test/unit_tests/braket/jobs/test_data_persistence.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
import numpy as np
import pytest

# todo: remove once circular import is fixed
import braket.aws # noqa: F401
from braket.jobs.data_persistence import (
load_job_checkpoint,
load_job_result,
Expand Down

0 comments on commit a7e799c

Please sign in to comment.