-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: upgrade AutoQASM to use oqpy 0.3.3 #715
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/autoqasm #715 +/- ##
===================================================
Coverage 100.00% 100.00%
===================================================
Files 160 162 +2
Lines 9498 9660 +162
Branches 2045 2080 +35
===================================================
+ Hits 9498 9660 +162
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions but no real change right now. I feel _format_parameter_ast
(here) does a good job at dispatch between FreeParameter and fixed value variables. Should we get inspiration from it?
Issue #, if available:
https://github.com/orgs/amazon-braket/projects/2/views/1?pane=issue&itemId=38519010
Description of changes:
Testing done:
tox
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.