Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: upgrade AutoQASM to use oqpy 0.3.3 #715

Merged
merged 19 commits into from
Oct 16, 2023

Conversation

yitchen-tim
Copy link
Contributor

@yitchen-tim yitchen-tim commented Sep 29, 2023

Issue #, if available:
https://github.com/orgs/amazon-braket/projects/2/views/1?pane=issue&itemId=38519010

Description of changes:

Testing done:
tox

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c544b77) 100.00% compared to head (f3bb8f9) 100.00%.
Report is 2 commits behind head on feature/autoqasm.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/autoqasm      #715    +/-   ##
===================================================
  Coverage            100.00%   100.00%            
===================================================
  Files                   160       162     +2     
  Lines                  9498      9660   +162     
  Branches               2045      2080    +35     
===================================================
+ Hits                   9498      9660   +162     
Files Coverage Δ
src/braket/experimental/autoqasm/api.py 100.00% <ø> (ø)
...raket/experimental/autoqasm/instructions/qubits.py 100.00% <100.00%> (ø)
...rc/braket/experimental/autoqasm/program/program.py 100.00% <100.00%> (ø)
src/braket/experimental/autoqasm/pulse/pulse.py 100.00% <100.00%> (ø)
.../braket/experimental/autoqasm/types/conversions.py 100.00% <ø> (ø)
src/braket/parametric/free_parameter_expression.py 100.00% <100.00%> (ø)
src/braket/pulse/ast/approximation_parser.py 100.00% <100.00%> (ø)
src/braket/pulse/ast/free_parameters.py 100.00% <100.00%> (ø)
src/braket/pulse/ast/qasm_parser.py 100.00% <100.00%> (ø)
src/braket/pulse/pulse_sequence.py 100.00% <100.00%> (ø)
... and 1 more

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmshaffer rmshaffer changed the title AutoQASM uses up-to-date oqpy main branch feature: upgrade AutoQASM to use oqpy 0.3.2 Oct 3, 2023
@rmshaffer rmshaffer marked this pull request as ready for review October 3, 2023 22:27
@rmshaffer rmshaffer requested a review from a team as a code owner October 3, 2023 22:27
@rmshaffer rmshaffer marked this pull request as draft October 4, 2023 13:56
Copy link
Contributor

@jcjaskula-aws jcjaskula-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions but no real change right now. I feel _format_parameter_ast (here) does a good job at dispatch between FreeParameter and fixed value variables. Should we get inspiration from it?

@rmshaffer rmshaffer changed the title feature: upgrade AutoQASM to use oqpy 0.3.2 feature: upgrade AutoQASM to use oqpy 0.3.3 Oct 16, 2023
@rmshaffer rmshaffer marked this pull request as ready for review October 16, 2023 18:34
@rmshaffer rmshaffer merged commit 5ea59f4 into feature/autoqasm Oct 16, 2023
22 checks passed
@rmshaffer rmshaffer deleted the rmshaffer/oqpy-upgrade branch October 16, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants