Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make filter more convenient #718

Merged
merged 11 commits into from
Dec 12, 2023

Conversation

jcjaskula-aws
Copy link
Contributor

@jcjaskula-aws jcjaskula-aws commented Sep 30, 2023

Issue #, if available:
With the current filter function, one cannot create a union of set of calibrations like all single 1q gates applicable to qubit 0 and 1.

Description of changes:
Added the possibility to pass list of QubitSet

Testing done:
Added test cases

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jcjaskula-aws jcjaskula-aws requested a review from a team as a code owner September 30, 2023 02:46
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37bad90) 100.00% compared to head (64b332a) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #718   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          129       129           
  Lines         8396      8398    +2     
  Branches      1870      1871    +1     
=========================================
+ Hits          8396      8398    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AbeCoull
AbeCoull previously approved these changes Oct 24, 2023
@jcjaskula-aws jcjaskula-aws force-pushed the jcjaskula-aws/fix_gate_calibration_filter branch from a96ff92 to 4acc53f Compare October 29, 2023 13:27
src/braket/circuits/gate_calibrations.py Outdated Show resolved Hide resolved
src/braket/circuits/gate_calibrations.py Outdated Show resolved Hide resolved
src/braket/circuits/gate_calibrations.py Outdated Show resolved Hide resolved
AbeCoull
AbeCoull previously approved these changes Dec 11, 2023
@jcjaskula-aws jcjaskula-aws force-pushed the jcjaskula-aws/fix_gate_calibration_filter branch from 858cea6 to b25ca48 Compare December 11, 2023 19:15
src/braket/circuits/gate_calibrations.py Outdated Show resolved Hide resolved
src/braket/circuits/gate_calibrations.py Outdated Show resolved Hide resolved
src/braket/circuits/gate_calibrations.py Outdated Show resolved Hide resolved
@jcjaskula-aws jcjaskula-aws force-pushed the jcjaskula-aws/fix_gate_calibration_filter branch from 7fb9ae0 to 64b332a Compare December 11, 2023 23:39
@jcjaskula-aws jcjaskula-aws merged commit 12f1387 into main Dec 12, 2023
24 checks passed
@jcjaskula-aws jcjaskula-aws deleted the jcjaskula-aws/fix_gate_calibration_filter branch December 12, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants