-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make filter more convenient #718
Merged
jcjaskula-aws
merged 11 commits into
main
from
jcjaskula-aws/fix_gate_calibration_filter
Dec 12, 2023
Merged
fix: make filter more convenient #718
jcjaskula-aws
merged 11 commits into
main
from
jcjaskula-aws/fix_gate_calibration_filter
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 129 129
Lines 8396 8398 +2
Branches 1870 1871 +1
=========================================
+ Hits 8396 8398 +2 ☔ View full report in Codecov by Sentry. |
AbeCoull
previously approved these changes
Oct 24, 2023
jcjaskula-aws
force-pushed
the
jcjaskula-aws/fix_gate_calibration_filter
branch
from
October 29, 2023 13:27
a96ff92
to
4acc53f
Compare
AbeCoull
reviewed
Nov 6, 2023
AbeCoull
previously approved these changes
Dec 11, 2023
jcjaskula-aws
force-pushed
the
jcjaskula-aws/fix_gate_calibration_filter
branch
from
December 11, 2023 19:15
858cea6
to
b25ca48
Compare
speller26
reviewed
Dec 11, 2023
speller26
approved these changes
Dec 11, 2023
jcjaskula-aws
force-pushed
the
jcjaskula-aws/fix_gate_calibration_filter
branch
from
December 11, 2023 23:39
7fb9ae0
to
64b332a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
With the current filter function, one cannot create a union of set of calibrations like all single 1q gates applicable to qubit 0 and 1.
Description of changes:
Added the possibility to pass list of QubitSet
Testing done:
Added test cases
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.