test: add full coverage #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bytestring sometimes wrapped in ", sometimes in ' |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/job-decorator #731 +/- ##
==========================================================
+ Coverage 99.96% 100.00% +0.03%
==========================================================
Files 129 129
Lines 8336 8335 -1
Branches 1857 1857
==========================================================
+ Hits 8333 8335 +2
+ Misses 2 0 -2
+ Partials 1 0 -1
☔ View full report in Codecov by Sentry. |
AbeCoull
reviewed
Oct 9, 2023
| @@ -158,6 +162,41 @@ def my_entry(a, b: int, c=0, d: float = 1.0, **extras) -> str: | |||
| mock_stdout.write.assert_any_call(s3_not_linked) | |||
|
|
|||
|
|
|||
| @patch("time.time", return_value=123.0) | |||
| @patch("builtins.open") | |||
| @patch("tempfile.TemporaryDirectory") | |||
There was a problem hiding this comment.
For clarity later on, it may be worthwhile to include why these patches are needed
There was a problem hiding this comment.
Perhaps, though I don't necessarily see this case as more opaque than a lot of our testing. Here we mock time to have a predictable job name, open to avoid actually creating any files, and tempdir to assert the correct temp dir gets created and removed
AbeCoull
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
add unit tests to cover missed lines of code
Testing done:
unit tests
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.