Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input data import in template #733

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

ajberdy
Copy link
Contributor

@ajberdy ajberdy commented Oct 10, 2023

Issue #, if available:

Description of changes:

import missing fix

Testing done:

manual verification + unit/integ

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajberdy ajberdy requested a review from a team as a code owner October 10, 2023 21:27
@ajberdy ajberdy requested a review from mbeach-aws October 10, 2023 21:28
mbeach-aws
mbeach-aws previously approved these changes Oct 10, 2023
@ajberdy
Copy link
Contributor Author

ajberdy commented Oct 10, 2023

Failing because of python 3.8 downgrade for now, no changes needed

@ajberdy ajberdy changed the base branch from feature/job-decorator to main October 10, 2023 21:37
@ajberdy ajberdy dismissed mbeach-aws’s stale review October 10, 2023 21:37

The base branch was changed.

@ajberdy ajberdy changed the base branch from main to feature/job-decorator October 10, 2023 21:38
@ajberdy ajberdy closed this Oct 10, 2023
@ajberdy ajberdy reopened this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3a883f6) 100.00% compared to head (bfc0ddf) 100.00%.
Report is 2 commits behind head on feature/job-decorator.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/job-decorator      #733   +/-   ##
=======================================================
  Coverage                 100.00%   100.00%           
=======================================================
  Files                        129       129           
  Lines                       8335      8335           
  Branches                    1857      1857           
=======================================================
  Hits                        8335      8335           
Files Coverage Δ
src/braket/jobs/_entry_point_template.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajberdy ajberdy requested a review from mbeach-aws October 10, 2023 21:42
@ajberdy ajberdy merged commit 29358fe into feature/job-decorator Oct 10, 2023
24 of 48 checks passed
@ajberdy ajberdy deleted the add-import branch October 10, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants