Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to 3.9 syntax #735

Merged
merged 2 commits into from
Oct 11, 2023
Merged

feat: update to 3.9 syntax #735

merged 2 commits into from
Oct 11, 2023

Conversation

ajberdy
Copy link
Contributor

@ajberdy ajberdy commented Oct 11, 2023

Issue #, if available:

Description of changes:

update typing and misc to utilize 3.9

Testing done:

unit tests and a bit of manual verification

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajberdy ajberdy requested a review from speller26 October 11, 2023 00:50
@ajberdy ajberdy requested a review from a team as a code owner October 11, 2023 00:50
src/braket/jobs/data_persistence.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (29358fe) 100.00% compared to head (45d61b2) 100.00%.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/job-decorator      #735   +/-   ##
=======================================================
  Coverage                 100.00%   100.00%           
=======================================================
  Files                        129       129           
  Lines                       8335      8338    +3     
  Branches                    1857      1857           
=======================================================
+ Hits                        8335      8338    +3     
Files Coverage Δ
src/braket/aws/aws_quantum_job.py 100.00% <100.00%> (ø)
src/braket/jobs/config.py 100.00% <100.00%> (ø)
src/braket/jobs/data_persistence.py 100.00% <100.00%> (ø)
src/braket/jobs/environment_variables.py 100.00% <100.00%> (ø)
src/braket/jobs/hybrid_job.py 100.00% <100.00%> (ø)
src/braket/jobs/local/local_job.py 100.00% <100.00%> (ø)
src/braket/jobs/quantum_job_creation.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Cody Wang <speller26@gmail.com>
@ajberdy ajberdy merged commit 6046dbd into feature/job-decorator Oct 11, 2023
22 checks passed
@ajberdy ajberdy deleted the update-typing branch October 11, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants