feat: sanitize hp strings #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/job-decorator #742 +/- ##
=======================================================
Coverage 100.00% 100.00%
=======================================================
Files 129 129
Lines 8381 8387 +6
Branches 1864 1866 +2
=======================================================
+ Hits 8381 8387 +6
☔ View full report in Codecov by Sentry. |
kshitijc
reviewed
Oct 13, 2023
src/braket/jobs/hybrid_job.py
Outdated
| .replace("\n", " ") | ||
| # replace forbidden characters with "?" | ||
| .replace("$", "?") | ||
| .replace("(", "?") |
There was a problem hiding this comment.
Would {} be a more natural replacement for ()?
src/braket/jobs/hybrid_job.py
Outdated
| # replace forbidden characters with "?" | ||
| .replace("$", "?") | ||
| .replace("(", "?") | ||
| .replace("&", "?") |
There was a problem hiding this comment.
Would amp; be a more natural replacement?
There was a problem hiding this comment.
I may prefer + to maintain the number of chars (for indexing and length constraints)
src/braket/jobs/hybrid_job.py
Outdated
| .replace("$", "?") | ||
| .replace("(", "?") | ||
| .replace("&", "?") | ||
| .replace("`", "?") |
There was a problem hiding this comment.
Would ' be a more natural replacement?
kshitijc
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
shorten long strings and replace forbidden chars with
?Testing done:
unit and manual testing
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.