Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update integ test for non-py310 #744

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: update integ test for non-py310 #744

merged 1 commit into from
Oct 16, 2023

Conversation

ajberdy
Copy link
Contributor

@ajberdy ajberdy commented Oct 16, 2023

Issue #, if available:

Description of changes:

Add try-catch around job definition to handle python version mismatch

Testing done:

verified integ tests passing in 3.9 and 3.10

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajberdy ajberdy requested a review from kshitijc October 16, 2023 18:10
@ajberdy ajberdy requested a review from a team as a code owner October 16, 2023 18:10
@ajberdy
Copy link
Contributor Author

ajberdy commented Oct 16, 2023

Try-catch to avoid duplication of code to check container python version. Manually checking for 3.10 is less stable

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (71ef0ec) 100.00% compared to head (dee86f9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #744   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          129       129           
  Lines         8387      8387           
  Branches      1866      1866           
=========================================
  Hits          8387      8387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajberdy ajberdy merged commit 56450e2 into main Oct 16, 2023
22 checks passed
@ajberdy ajberdy deleted the integ-catch branch October 16, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants