Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fixup numerical imprecision #770

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

laurencap
Copy link
Contributor

Issue #, if available:

Description of changes:
Thank you @yitchen-tim and @rmshaffer for catching my mistake!

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurencap laurencap requested a review from a team as a code owner October 30, 2023 19:27
@laurencap laurencap requested review from rmshaffer and yitchen-tim and removed request for a team October 30, 2023 19:27
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a68b6c) 100.00% compared to head (fb58273) 100.00%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           feature/autoqasm      #770   +/-   ##
==================================================
  Coverage            100.00%   100.00%           
==================================================
  Files                   162       162           
  Lines                  9653      9653           
  Branches               2076      2076           
==================================================
  Hits                   9653      9653           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rmshaffer rmshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@laurencap laurencap merged commit 5459174 into amazon-braket:feature/autoqasm Oct 30, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants