[fix] Update AutoQASM to consume qubit types from braket.registers module #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmshaffer
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/autoqasm #771 +/- ##
==================================================
Coverage 100.00% 100.00%
==================================================
Files 163 163
Lines 9758 9759 +1
Branches 2080 2080
==================================================
+ Hits 9758 9759 +1
☔ View full report in Codecov by Sentry. |
rmshaffer
commented
Oct 31, 2023
| # a hard-coded global qubit register. | ||
| return f"{constants.QUBIT_REGISTER}[{qubit_idx_expr}]" | ||
| def _global_qubit_register(qubit_idx_expr: Union[int, str]) -> oqpy.Qubit: | ||
| return oqpy.Qubit(f"{constants.QUBIT_REGISTER}[{qubit_idx_expr}]", needs_declaration=False) |
There was a problem hiding this comment.
I removed the "TODO" comment because the oqpy qubit register is not actually created/declared at this point (that happens near the end of the program creation process), and I don't think there's a better way to index into it than what we're doing here.
laurencap
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
QubitandQubitSettypes from thebraket.registersmodule.Testing done:
toxpasses.Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.