Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't run pulse tests when QPU offline #773

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix: Don't run pulse tests when QPU offline #773

merged 2 commits into from
Oct 31, 2023

Conversation

speller26
Copy link
Member

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@speller26 speller26 requested a review from ajberdy October 31, 2023 01:24
@speller26 speller26 requested a review from a team as a code owner October 31, 2023 01:24
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d10497a) 100.00% compared to head (e4901c1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #773   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          129       129           
  Lines         8360      8360           
  Branches      1862      1862           
=========================================
  Hits          8360      8360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ajberdy
ajberdy previously approved these changes Oct 31, 2023
Copy link
Contributor

@ajberdy ajberdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth changing return to pytest.skip("device offline")

@speller26 speller26 merged commit facb2fe into main Oct 31, 2023
22 checks passed
@speller26 speller26 deleted the pulse branch October 31, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants