Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify entry point wrapper #781

Merged
merged 1 commit into from
Nov 2, 2023
Merged

feat: simplify entry point wrapper #781

merged 1 commit into from
Nov 2, 2023

Conversation

ajberdy
Copy link
Contributor

@ajberdy ajberdy commented Nov 2, 2023

Issue #, if available:

Description of changes:

Use the standard approach for creating a partial function instead of building our own.

Testing done:

unit/integ tests passing

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajberdy ajberdy requested a review from a team as a code owner November 2, 2023 19:44
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f4938e) 100.00% compared to head (94d8c21) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #781   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          129       129           
  Lines         8360      8359    -1     
  Branches      1862      1862           
=========================================
- Hits          8360      8359    -1     
Files Coverage Δ
src/braket/jobs/hybrid_job.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajberdy ajberdy merged commit ef4c92f into main Nov 2, 2023
22 checks passed
@ajberdy ajberdy deleted the partial branch November 2, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants