fix: AutoQASM measurement of physical qubits #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/autoqasm #788 +/- ##
==================================================
Coverage 100.00% 100.00%
==================================================
Files 163 163
Lines 9774 9773 -1
Branches 2084 2084
==================================================
- Hits 9774 9773 -1
☔ View full report in Codecov by Sentry. |
laurencap
reviewed
Nov 7, 2023
| bit b; | ||
| bit[2] c; | ||
| bit __bit_0__; | ||
| __bit_0__ = measure $0; |
There was a problem hiding this comment.
wow can't believe we were missing this case! glad you found it
laurencap
reviewed
Nov 7, 2023
| @@ -42,7 +46,7 @@ def measure(qubits: Union[QubitIdentifierType, Iterable[QubitIdentifierType]]) - | |||
| Returns: | |||
| BitVar: Bit variable the measurement results are assigned to. | |||
| """ | |||
| if not isinstance(qubits, Iterable): | |||
| if is_qubit_identifier_type(qubits): | |||
There was a problem hiding this comment.
I always seem to forget that str is an Iterable
laurencap
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
measureso that we handle physical qubits (i.e., strings) correctly.Testing done:
tox -e notebookspasses locally.Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.