Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: adding a test to check for circular imports #812

Merged
merged 6 commits into from
Dec 6, 2023
Merged

Conversation

krneta
Copy link
Contributor

@krneta krneta commented Nov 27, 2023

Issue #, if available:

Description of changes:

Testing done:
I reset back to where we had the issue with eed59ff change, and then verified that I could detect the issue regardless of the order that the modules were tested in.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@krneta krneta requested review from kshitijc and AbeCoull November 27, 2023 19:34
@krneta krneta requested a review from a team as a code owner November 27, 2023 20:15
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aea53ae) 100.00% compared to head (046bae3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #812   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          129       129           
  Lines         8388      8388           
  Branches      1870      1870           
=========================================
  Hits          8388      8388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbeCoull
Copy link
Contributor

Should consistent start methods across OS's be confirmed with https://docs.python.org/3/library/multiprocessing.html#multiprocessing.set_start_method

@krneta
Copy link
Contributor Author

krneta commented Nov 28, 2023

Should consistent start methods across OS's be confirmed with https://docs.python.org/3/library/multiprocessing.html#multiprocessing.set_start_method

Do you mean that we should be using spawn on linux? Why? It doesn't seem it would make a difference here?

kshitijc
kshitijc previously approved these changes Nov 28, 2023
Copy link
Contributor

@kshitijc kshitijc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change!

@krneta
Copy link
Contributor Author

krneta commented Nov 29, 2023

Should consistent start methods across OS's be confirmed with https://docs.python.org/3/library/multiprocessing.html#multiprocessing.set_start_method

While talking offline, Abe brought up the point that the parent process could have imports that could carry over to the children with 'fork'. I'm not sure about that, but it seems fairly safe to set them all to 'spawn'.

@speller26
Copy link
Member

speller26 commented Dec 6, 2023

Note: use the prefix test: for the commit

@krneta krneta merged commit 2bb1e74 into main Dec 6, 2023
26 checks passed
@krneta krneta deleted the circ_import_test branch December 6, 2023 18:07
@krneta
Copy link
Contributor Author

krneta commented Dec 6, 2023

Note: use the prefix test: for the commit

Sorry, I didn't see this in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants