Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add queue position to the logs for tasks and jobs #821

Merged
merged 10 commits into from
Jan 22, 2024
Merged

Conversation

AbeCoull
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b5f690) 100.00% compared to head (ba17ad9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #821   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          129       129           
  Lines         8519      8531   +12     
  Branches      1905      1908    +3     
=========================================
+ Hits          8519      8531   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbeCoull AbeCoull marked this pull request as ready for review November 29, 2023 20:43
@AbeCoull AbeCoull requested a review from a team as a code owner November 29, 2023 20:43
Copy link
Contributor

@ajberdy ajberdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AbeCoull AbeCoull merged commit 7df9aa7 into main Jan 22, 2024
24 checks passed
@AbeCoull AbeCoull deleted the queue_logs branch January 22, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants