Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discretize method now takes None as an arg #950

Merged
merged 7 commits into from
Apr 15, 2024
Merged

fix: discretize method now takes None as an arg #950

merged 7 commits into from
Apr 15, 2024

Conversation

AbeCoull
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AbeCoull AbeCoull requested a review from a team as a code owner April 11, 2024 18:34
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6e9a2dc) to head (324913d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #950   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          134       134           
  Lines         8911      8924   +13     
  Branches      2007      2010    +3     
=========================================
+ Hits          8911      8924   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rchilaka-amzn
rchilaka-amzn previously approved these changes Apr 12, 2024
@AbeCoull AbeCoull merged commit 5ed6590 into main Apr 15, 2024
24 checks passed
@AbeCoull AbeCoull deleted the discretize branch April 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants