-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Error when FreeParameters are named QASM types #999
fix: Error when FreeParameters are named QASM types #999
Conversation
I have raised another PR #268 in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution! I've left a few small comments, but I think this is on the right track!
Add openpulse keywords
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 135 135
Lines 8943 8949 +6
Branches 2009 2011 +2
=========================================
+ Hits 8943 8949 +6 ☔ View full report in Codecov by Sentry. |
Hi, I'm not sure why the Dependent tests are failing for Windows with the following error message:
Can someone help? Thanks! |
I think this must have been some intermittent error downloading from PyPI. I'm re-running the failed tests and they appear to be succeeding now. |
Hi @rmshaffer , is this PR ready to be merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for this contribution!
Hi @rmshaffer , can this be merged to main so that #603 can be closed :). |
Issue: Fixes #603
Description of changes:
FreeParameter
is restricted now. Any SDK predefined variables or OpenQasm reserved identifiers cannot be used to as names ofFreeParameter
.Testing done:
Unit test has been added.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.