perf: add dynamically loaded cache-dependencies for actions python #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the main bundle size by⚠️ 1.28 MB minified! This bundle is loaded only when caching is enabled. `setup-python` is used in [`setup-cpp`](https://github.com/aminya/setup-cpp) as a library. This optimization reduces the bundle size for that package as well. The build system of `setup-python` uses `ncc`, which doesn't immediately benefit from this change, but setup-cpp uses `Parcel`, which shows this huge improvement. The reason for this huge reduction is that caching the dependencies uses the `@actions/cache` package, which is an extremely large package with big dependencies. The bundle size before this separation shows this: 
aminya
force-pushed
the
setup-python-bundle
branch
from
d8ed5b1 to
96396ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the main bundle size by⚠️ 1.28 MB minified! This bundle is loaded only when caching is enabled.
setup-pythonis used insetup-cppas a library. This optimization reduces the bundle size for that package as well. The build system ofsetup-pythonusesncc, which doesn't immediately benefit from this change, but setup-cpp usesParcel, which shows this huge improvement.The reason for this huge reduction is that caching the dependencies uses the
@actions/cachepackage, which is an extremely large package with big dependencies. The bundle size before this separation shows this:actions/setup-python#728