Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE :: Update Background Keyboard #64

Merged
merged 10 commits into from
Feb 16, 2024
Merged

FEATURE :: Update Background Keyboard #64

merged 10 commits into from
Feb 16, 2024

Conversation

amirisback
Copy link
Owner

No description provided.

@amirisback amirisback added the enhancement New feature or request label Feb 16, 2024
@amirisback amirisback self-assigned this Feb 16, 2024
@amirisback amirisback mentioned this pull request Feb 16, 2024
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 16, 2024
View reviewed changes
app/src/main/java/com/frogobox/appkeyboard/ui/test/TestViewModel.kt
@@ -1,4 +1,4 @@
package com.frogobox.appkeyboard.ui.detail
package com.frogobox.appkeyboard.ui.test

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning test

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/ui/test/TestViewModel.kt is not ending with a new line.
app/src/main/java/com/frogobox/appkeyboard/ui/test/TestActivity.kt
@@ -1,25 +1,25 @@
package com.frogobox.appkeyboard.ui.detail
package com.frogobox.appkeyboard.ui.test

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning test

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/ui/test/TestActivity.kt is not ending with a new line.
frogo-keyboard/src/main/java/com/frogobox/libkeyboard/ui/main/ItemMainKeyboard.kt
val a = res.obtainAttributes(Xml.asAttributeSet(parser), R.styleable.KwKeyboard)
mDefaultWidth = getDimensionOrFraction(a, R.styleable.KwKeyboard_keyWidth, mDisplayWidth, mDisplayWidth / 10)
val a = res.obtainAttributes(Xml.asAttributeSet(parser), R.styleable.FrogoKeyboard)
mDefaultWidth = getDimensionOrFraction(a, R.styleable.FrogoKeyboard_keyWidth, mDisplayWidth, mDisplayWidth / 10)

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.
frogo-keyboard/src/main/java/com/frogobox/libkeyboard/ui/main/MainKeyboard.kt
isAntiAlias = true
textSize = keyTextSize.toFloat()
textAlign = Align.CENTER
alpha = 255

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.
@amirisback amirisback merged commit ec2c42e into master Feb 16, 2024
4 checks passed
@amirisback amirisback deleted the develop/update-background-keyboard branch November 14, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amirisback amirisback

Labels
enhancement New feature or request
Projects
Faisal Amir Open Sources
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amirisback