Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

[feat] add ability to customize template by setting property on controller con... #157

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hannahhoward
Copy link

...structor

After thinking about #154 I decided a good first step would be to allow you to set a $template on a controller's constructor that will override the default template url returned by componentLoaderProvider.

The syntax is essentially:

function MyController(...) {
...
}
MyController.$template = {
   url: 'anyDirectory/anyTemplateName.html'
}

This is in line with where #129 is headed and also matches nicely with the Angular 2 component syntax (it could become an annotation instead of a property just like the template annotation in Angular 2). It also allows you to add support for inline templates, so this works:

function MyController(...) {
...
}
MyController.$template = {
   inline: '<div>Hello!</div>'
}

Anyway, would love feedback if this seems like a good idea.

Also I'm not sure why it shows a bunch of additional changes from what looks like previous commits.

Review on Reviewable

@nyarly
Copy link

nyarly commented Mar 9, 2015

+1

@hannahhoward
Copy link
Author

sorry actually commited changes to the dist dir, fixed now. apologies

@hannahhoward
Copy link
Author

oops one more piece of code accidentally left in. wow sloppy :)

@hannahhoward
Copy link
Author

i now see angular/angular.js#10007 is probably a more elegant solution to this issue, if it moves forward.

@btford
Copy link
Contributor

btford commented Mar 10, 2015

We'll see. A proposal like yours also came up during today's 1.x meeting.

Thanks so much for all of your great comments and feedback, btw. I really appreciate it! It'll probably take me a bit longer than I'd like to get around to coalescing and responding to this wave of feedback following ng-conf, but I'm hoping to have more concrete ideas for these big issues this week.

Until then, thanks for your patience!

@btford btford force-pushed the master branch 4 times, most recently from ee0fae2 to 1af7b8e Compare March 17, 2015 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants