Fix sonar issues

animatinetpacs · Dec 27, 2024 · a1eff30 · a1eff30
1 parent 46b3b7c
commit a1eff30
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 11 deletions.
diff --git a/weasis-dicom/weasis-dicom-codec/src/main/java/org/weasis/dicom/codec/DicomSeries.java b/weasis-dicom/weasis-dicom-codec/src/main/java/org/weasis/dicom/codec/DicomSeries.java
@@ -150,7 +150,7 @@ public String getMimeType() {
   }
 
   @Override
-  public void dispose() {
+  public synchronized void dispose() {
     stopPreloading(this);
     String seriesUID = (String) getTagValue(getTagID());
     String modality = TagD.getTagValue(this, Tag.Modality, String.class);

diff --git a/weasis-dicom/weasis-dicom-rt/src/main/java/org/weasis/dicom/rt/Plan.java b/weasis-dicom/weasis-dicom-rt/src/main/java/org/weasis/dicom/rt/Plan.java
@@ -21,7 +21,6 @@
  */
 public class Plan extends RtSpecialElement {
   private String sopInstanceUid;
-  private String label;
   private Date date;
   private String name;
   private String description;
@@ -41,10 +40,6 @@ public void setSopInstanceUid(String sopInstanceUid) {
     this.sopInstanceUid = sopInstanceUid;
   }
 
-  public String getLabel() {
-    return this.label;
-  }
-
   public void setLabel(String value) {
     this.label = value;
   }

diff --git a/...icom/weasis-dicom-viewer2d/src/main/java/org/weasis/dicom/viewer2d/mpr/OriginalStack.java b/...icom/weasis-dicom-viewer2d/src/main/java/org/weasis/dicom/viewer2d/mpr/OriginalStack.java
@@ -11,13 +11,11 @@
 
 import static org.weasis.dicom.viewer2d.mpr.MprView.SliceOrientation.AXIAL;
 
-import java.io.File;
 import java.util.Arrays;
 import java.util.List;
 import org.dcm4che3.data.Attributes;
 import org.dcm4che3.data.Tag;
 import org.dcm4che3.data.VR;
-import org.weasis.core.api.gui.util.AppProperties;
 import org.weasis.core.api.gui.util.Filter;
 import org.weasis.core.api.media.data.MediaSeries;
 import org.weasis.core.api.media.data.TagW;
@@ -29,9 +27,6 @@
 
 public abstract class OriginalStack extends AbstractStack {
   protected static final double EPSILON = 1e-3;
-  protected static final File MPR_CACHE_DIR =
-      AppProperties.buildAccessibleTempDirectory(
-          AppProperties.FILE_CACHE_DIR.getName(), "mpr"); // NON-NLS
   static TagW seriesReferences = new TagW("series.builder.refs", TagType.STRING, 2, 2);
   static final int[] COPIED_ATTRS = {
     Tag.SpecificCharacterSet,