Deeplink to reviewer closes everything #17662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthur-Milchior
force-pushed
the
LaunchType
branch
3 times, most recently
from
3cbd1fd to
c0dc16d
Compare
Arthur-Milchior
changed the title
david-allison
added
the
Needs Second Approval
mikehardy
approved these changes
Jan 4, 2025
Currently, the code ensured there was at most one IntentHandler. We honestly don't care about it. The intended meaning was that there is a single reviewer. This bug was probably introduced in ankidroid#17422 with commit f26aa95. I would love to test to avoid another regression. However, it's really not clear to me how to deal with shortcuts, widget or remainders as they are outside of the main app. I discovered that having a single reviewer is still not enough. Because what is below the reviewer could be nonsense. Instead, I followed standard practice for deep link. I close everything and create a fresh stack. Bug ankidroid#16956. Fixes ankidroid#17664. Co-authored-by: Mike Hardy <github@mikehardy.net>
david-allison
force-pushed
the
LaunchType
branch
from
743c4e8 to
d8b47d8
Compare
david-allison
approved these changes
Jan 4, 2025
github-actions
bot
removed
the
Needs Second Approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code ensured there was at most one IntentHandler. We
honestly don't care about it. The intended meaning was that there is a
single reviewer.
This bug was probably introduced in #17422 with commit
f26aa95.
I would love to test to avoid another regression. However, it's really
not clear to me how to deal with shortcuts, widget or remainders as
they are outside of the main app.
I discovered that having a single reviewer is still not
enough. Because what is below the reviewer could be nonsense. Instead,
I followed standard practice for deep link. I close everything and
create a fresh stack.