improvement: introduce DeckPickerViewModel

[david-allison]

Purpose / Description

We want more ViewModels in 2025. Let it start

Approach

• Extract launchCollectionInLifecycleScope
• Document remove
• Create class
• Bring method across

How Has This Been Tested?

Deleted a deck in the UI of an API 34 emulator via context menu

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

This could be part of an 'undoableSnackbar' flow, didn't seem useful

[david-allison]

We really have 3:

• Delete [collection] Selected Deck
• Delete Focused Deck
• Delete DeckID

At 3, we can potentially parameterize the method: added complexity in the VM, for 4/5 less lines in the Activity

But it's probably best to stop using 'Delete [collection] Selected Deck' to avoid race conditions

[david-allison]

@SanjaySargam showDeleteDeckConfirmationDialog is only used when pressing 'DEL', in all other cases, we delete unconditionally and show an 'undo' snackbar

Was this intentional?

[SanjaySargam]

Yes it is intentional.

            KeyEvent.KEYCODE_DEL -> {
                // This action on a deck should only occur when the user see the deck name very clearly,
                // that is, when it appears in the trailing study option fragment
                if (fragmented) {
                    if (event.isShiftPressed) {
                        // Shortcut: Shift + DEL - Delete deck without confirmation dialog
                        Timber.i("Shift+DEL: Deck deck without confirmation")
                        deleteDeck(focusedDeck)
                    } else {
                        // Shortcut: DEL
                        Timber.i("Delete Deck from keypress")
                        showDeleteDeckConfirmationDialog()
                    }
                    return true
                }
            }