Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add Uyghur language #17700

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

mikehardy
Copy link
Member

@mikehardy mikehardy commented Jan 2, 2025

Going with Unicode presentation of Uyghur in language picker

Needs current strings to go through

Then we should merge this (assuming it looks like I got all the things?) then do another sync

Followed instructions here:

// The rules for making changes here:
// 1) Add a language if 01-core.xml is translated
// 2) Do not remove languages.
// 3) When you add a language, please also add it to APP_LANGUAGES in LanguageUtil.kt
// BACKEND_LANGS in LanguageUtil is informational and not used for anything, so it's not imperative
// to keep it up to date.
// 4) If you add a language with a regional variant (anything with a hyphen) and a different variant
// with the same root exists, you must add the root to 'localizedRegions'
// e.g., 'ga-IE' exists with no other 'ga-' entries yet, to add 'ga-EN', also add ga to localizedRegions
// 5) Update MissingDefaultResource in lint-release.xml

@@ -204,6 +204,8 @@ object LanguageUtil {
"Tsonga" to "ts",
// Tatar (Russia)
"Татар (Россия)" to "tt-RU",
// Uyghur
"ئۇيغۇر تىلى" to "ug",
Copy link
Member

@david-allison david-allison Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang it, I really struggled with that one too, I tried 😆
Is CLDR just the canonical reference? I suppose it should be.
But checking with the translator is likely best. Will pose the question

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going with Unicode spec, left it open for reviewer to override with a fixup later

@mikehardy mikehardy added the Needs Author Reply Waiting for a reply from the original author label Jan 2, 2025
@mikehardy mikehardy force-pushed the add-uyghur-translation branch from c41ba6d to 7689c44 Compare January 2, 2025 18:23
@mikehardy
Copy link
Member Author

updated docs to note test needs update as well
pushed new language add commit that updates the test

just waiting for translator response now on preferred spelling of Uyghur in Uyghur script

@mikehardy mikehardy force-pushed the add-uyghur-translation branch from 7689c44 to 6f86a47 Compare January 4, 2025 16:19
@mikehardy mikehardy force-pushed the add-uyghur-translation branch from 6f86a47 to 5d00da2 Compare January 4, 2025 16:28
@mikehardy mikehardy removed the Needs Author Reply Waiting for a reply from the original author label Jan 4, 2025
@mikehardy
Copy link
Member Author

re-self-reviewed, I think it's all good now with last push

@david-allison david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Jan 4, 2025
@david-allison
Copy link
Member

Pending Strings

@mikehardy
Copy link
Member Author

mikehardy commented Jan 4, 2025

Tiny changes to Swedish since last strings build, running now

@mikehardy mikehardy added this pull request to the merge queue Jan 4, 2025
Merged via the queue into ankidroid:main with commit 63d3f6f Jan 4, 2025
9 checks passed
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 4, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Jan 4, 2025
@mikehardy mikehardy deleted the add-uyghur-translation branch January 4, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants