-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): add Uyghur language #17700
Conversation
@@ -204,6 +204,8 @@ object LanguageUtil { | |||
"Tsonga" to "ts", | |||
// Tatar (Russia) | |||
"Татар (Россия)" to "tt-RU", | |||
// Uyghur | |||
"ئۇيغۇر تىلى" to "ug", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't match CLDR: https://github.com/unicode-org/cldr/blob/9bbbc7769d6824229c49817c143ca7afebb00a34/common/main/ug.xml#L490
Check with translator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang it, I really struggled with that one too, I tried 😆
Is CLDR just the canonical reference? I suppose it should be.
But checking with the translator is likely best. Will pose the question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going with Unicode spec, left it open for reviewer to override with a fixup later
c41ba6d
to
7689c44
Compare
updated docs to note test needs update as well just waiting for translator response now on preferred spelling of Uyghur in Uyghur script |
7689c44
to
6f86a47
Compare
currently using Unicode Spec definition of "Uyghur" for language selection menu presentation https://github.com/unicode-org/cldr/blob/9bbbc7769d6824229c49817c143ca7afebb00a34/common/main/ug.xml#L490
6f86a47
to
5d00da2
Compare
re-self-reviewed, I think it's all good now with last push |
Pending Strings |
Tiny changes to Swedish since last strings build, running now |
Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR. Read more about updating strings on the wiki, |
Going with Unicode presentation of Uyghur in language picker
Needs current strings to go through
Then we should merge this (assuming it looks like I got all the things?) then do another sync
Followed instructions here:
Anki-Android/tools/localization/src/constants.ts
Lines 72 to 81 in 5bfc04c