Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:focus keyboard #17705

Merged
merged 1 commit into from
Jan 4, 2025
Merged

fix:focus keyboard #17705

merged 1 commit into from
Jan 4, 2025

Conversation

gayatriii0803
Copy link
Contributor

Purpose / Description

Keyboard is not opening on adding tags (TagsDialog).

Approach

Set displayKeyboard to true

How Has This Been Tested?

Physical device (OPPO F21 Pro 5G).
https://github.com/user-attachments/assets/eedb754a-be65-402e-9a5e-49a3a8b49e37

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label Jan 3, 2025
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mikehardy mikehardy added this pull request to the merge queue Jan 4, 2025
Merged via the queue into ankidroid:main with commit 7b689e5 Jan 4, 2025
12 checks passed
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Jan 4, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants