Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(custom-study): disable unusable items #17709

Merged
merged 3 commits into from
Jan 4, 2025
Merged

improvement(custom-study): disable unusable items #17709

merged 3 commits into from
Jan 4, 2025
+157 −77

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Jan 3, 2025 •
edited
Loading

Purpose / Description

It was requested that the unusable items were disabled rather than removed

Issue

Approach

Use a custom ListView to make it happen, styled the same as the standard one, because clicking on the standard one closes the dialog
Then style it the same
Then handle disabling ripple effects

How Has This Been Tested?

Learning (optional, can help others)

Android is no fun. This took too long

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison mentioned this pull request Jan 3, 2025
Closed
@david-allison
Copy link
Member Author

I'd be tempted to say we want an integration test with FSRS enabled, to catch when upstream changes the implementation

@david-allison david-allison requested a review from lukstbit January 4, 2025 11:55
lukstbit
lukstbit approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/customstudy/CustomStudyDialog.kt Outdated Show resolved Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/utils/ext/View.kt Outdated Show resolved Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/customstudy/CustomStudyDialog.kt Outdated Show resolved Hide resolved
@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 4, 2025
mikehardy
mikehardy approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikehardy mikehardy added this pull request to the merge queue Jan 4, 2025
@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 4, 2025
Merged via the queue into ankidroid:main with commit 61a6bea Jan 4, 2025
9 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 4, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukstbit lukstbit lukstbit approved these changes

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.21 release
Development

Successfully merging this pull request may close these issues.

Custom study menu should have Increase Today's new/review card limit
3 participants
@david-allison @mikehardy @lukstbit