Promote the win_hotfix Module from community #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble-collections#65) * removing chocolatey as they have moved to chocolatey.chocolatey * more chocolatey removals * fix sanity error * fixing one last time I hope
* Fix up docs after migration * Fix up sanity errors
* fix up sanity ignores * Bump ansible-windows dep * Fix bad change for win_region
* Rebalance the test targets * Make sure IIS test removes the service so our httptester works
* Update win_hotfix.ps1 * Fix up docs and return values Co-authored-by: Jordan Borean <jborean93@gmail.com>
jborean93
reviewed
Dec 4, 2024
jborean93
approved these changes
Dec 4, 2024
|
Looks like the PR needs a rebase with the latest changes in the main branch. |
Yaish25491
force-pushed
the
aap-36369-hotfix
branch
2 times, most recently
from
dc12ee3 to
4fa0434
Compare
|
branch rebased and changes added |
jborean93
reviewed
Dec 5, 2024
| module: win_hotfix | ||
| short_description: Install and uninstalls Windows hotfixes | ||
| description: | ||
| - Install, uninstall a Windows hotfix. |
There was a problem hiding this comment.
Needs the version added entry.
plugins/modules/win_hotfix.py
Outdated
Comment on lines
70
to
108
| community.windows.win_hotfix: | ||
| source: C:\temp\windows8.1-kb3172729-x64_e8003822a7ef4705cbb65623b72fd3cec73fe222.msu | ||
| state: present | ||
| register: hotfix_install | ||
|
|
||
| - ansible.windows.win_reboot: | ||
| when: hotfix_install.reboot_required | ||
|
|
||
| - name: Install hotfix validating KB | ||
| community.windows.win_hotfix: | ||
| hotfix_kb: KB3172729 | ||
| source: C:\temp\windows8.1-kb3172729-x64_e8003822a7ef4705cbb65623b72fd3cec73fe222.msu | ||
| state: present | ||
| register: hotfix_install | ||
|
|
||
| - ansible.windows.win_reboot: | ||
| when: hotfix_install.reboot_required | ||
|
|
||
| - name: Install hotfix validating Identifier | ||
| community.windows.win_hotfix: | ||
| hotfix_identifier: Package_for_KB3172729~31bf3856ad364e35~amd64~~6.3.1.0 | ||
| source: C:\temp\windows8.1-kb3172729-x64_e8003822a7ef4705cbb65623b72fd3cec73fe222.msu | ||
| state: present | ||
| register: hotfix_install | ||
|
|
||
| - ansible.windows.win_reboot: | ||
| when: hotfix_install.reboot_required | ||
|
|
||
| - name: Uninstall hotfix with Identifier | ||
| community.windows.win_hotfix: | ||
| hotfix_identifier: Package_for_KB3172729~31bf3856ad364e35~amd64~~6.3.1.0 | ||
| state: absent | ||
| register: hotfix_uninstall | ||
|
|
||
| - ansible.windows.win_reboot: | ||
| when: hotfix_uninstall.reboot_required | ||
|
|
||
| - name: Uninstall hotfix with KB (not recommended) | ||
| community.windows.win_hotfix: |
There was a problem hiding this comment.
Needs to change from community.windows.win_hotfix to ansible.windows.win_hotfix.
Yaish25491
force-pushed
the
aap-36369-hotfix
branch
from
4fa0434 to
eb3b479
Compare
|
Changes were added again after being lost while rebasing |
jborean93
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Promote the win_hotfix Module from community
Updating documentation examples.
ISSUE TYPE
COMPONENT NAME
plugins/modules/win_hotfix.ps1
plugins/modules/win_hotfix.py
tests/integration/targets/win_hotfix/aliases
tests/integration/targets/win_hotfix/defaults/main.yml
tests/integration/targets/win_hotfix/tasks/main.yml
tests/integration/targets/win_hotfix/tasks/tests.yml
tests/integration/targets/win_hotfix/tasks/tests_2012R2.yml