Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.18] fix reset_connection with templated connection variables (#84240) #84439

Open
wants to merge 1 commit into
base: stable-2.18
Choose a base branch
from

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Dec 5, 2024

SUMMARY

Backport for #84240

  • ssh: Test reset_connection with templated ansible_ssh_executable

Add failing test to confirm subsequent fixes are necessary & sufficient.

  • ssh: Fix reset_connection with templated ansible_ssh_executable

Signed-off-by: Alex Willmer alex@moreati.org.uk
(cherry picked from commit 59d9737)

ISSUE TYPE
  • Bugfix Pull Request

* ssh: Test reset_connection with templated ansible_ssh_executable

Add failing test to confirm subsequent fixes are necessary & sufficient.

* ssh: Fix reset_connection with templated ansible_ssh_executable

Signed-off-by: Alex Willmer <alex@moreati.org.uk>
(cherry picked from commit 59d9737)
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. backport This PR does not target the devel branch. labels Dec 5, 2024
@moreati
Copy link
Contributor

moreati commented Dec 16, 2024

Please wait before merging this backport. #84240 may have introduced a different bug, I'm checking now. I'll raise issue(s), update here as appropriate.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 16, 2024
@moreati
Copy link
Contributor

moreati commented Dec 16, 2024

False alarm, feel free to merge this backport. Sorry for the noise.

I was worried that task timeout (set by timeout keyword) was overwriting the connection timeout option, but this is not occuring - based on https://gist.github.com/moreati/697f90ab5ac7252ed1add937658348ca. I believe the errant overwriting only occurs in my Mitogen branch for mitogen-hq/mitogen#1201.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants