Add Checkstyle ExplicitInitialization

apache · Dec 29, 2024 · bfe3233 · bfe3233
1 parent d6608c0
commit bfe3233
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/conf/checkstyle/checkstyle.xml b/src/conf/checkstyle/checkstyle.xml
@@ -54,6 +54,8 @@ limitations under the License.
     <module name="EmptyBlock">
       <property name="option" value="text" />
     </module>
+    <!-- <module name="EqualsHashCode" /> -->
+    <module name="ExplicitInitializationCheck" />
     <module name="FinalLocalVariable" />
     <module name="IllegalImport" />
     <module name="ImportOrder">

diff --git a/src/main/java/org/apache/commons/compress/compressors/gzip/ExtraField.java b/src/main/java/org/apache/commons/compress/compressors/gzip/ExtraField.java
@@ -142,7 +142,7 @@ static ExtraField fromBytes(final byte[] bytes) throws IOException {
 
     private final List<SubField> subFields = new ArrayList<>();
 
-    private int totalSize = 0;
+    private int totalSize;
 
     /**
      * Constructs a new instance.

diff --git a/src/test/java/org/apache/commons/compress/archivers/zip/Lister.java b/src/test/java/org/apache/commons/compress/archivers/zip/Lister.java
@@ -41,10 +41,11 @@
 public final class Lister {
 
     private static final class CommandLine {
+
         String archive;
-        boolean useStream = false;
+        boolean useStream;
         String encoding;
-        boolean allowStoredEntriesWithDataDescriptor = false;
+        boolean allowStoredEntriesWithDataDescriptor;
         Path dir;
     }