Remove out of date jar and scripts #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have jar files in the repository? Gross. I'd rather get rid of this since it will automatically go out of date with the next release, and the next one. I never use it. The GitHub CI doesn't either. |
|
I mean...personally, I like the wrapper scripts. But if you want, I can change this PR to simply remove the wrapper :) Should I do that? |
|
Hi @beatbrot |
Sure, go for it. TY. |
|
@garydgregory Done :) |
garydgregory
changed the title
asfgit
pushed a commit
that referenced
this pull request
Feb 21, 2024
asfgit
pushed a commit
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the maven wrapper is currently broken since the
org.apache.maven.plugins:maven-enforcer-pluginplugin requires at least maven 3.6.3. The committed maven wrapper uses version 3.5.0.This PR updates the wrapper straight to 3.9.6 which fixes the issue.